NIP-46 bunker requests have no timeout and surface raw signer errors to users #19
Labels
No labels
bug
discussion
enhancement
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
edufeed/edufeed-app#19
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Found while investigating #4.
NostrConnectSignerrequests have no timeout: if the remote signer (nsec.app, Amber) is asleep on the first sign request of a session, the UI hangs in "Applying changes…" forever. After a reload the bunker is awake and signing works — matching the "first try fails, works after reload" report in #4.Needs: a timeout + user-facing "waiting for your signing app…" state around NIP-46 sign requests, and wrapping remote errors with a hint that they come from the connected signer. Note commit
ed7cf6d9fixed the stuck-queue variant for NIP-07 extensions only; bunker accounts were left untouched.Core fix on branch
fix/issue-19-bunker-signing(unit-tested): bunker (nostr-connect) accounts keep their signing queue but the signer is wrapped so signEvent rejects after 90s ("…the signer did not respond") instead of hanging on a sleeping remote app, and remote error strings are rethrown with attribution ("Your remote signing app reported an error: exceeded quota") instead of surfacing raw. Follow-ups still worth doing here: a "waiting for your signing app…" UI state during pending NIP-46 requests, and the same wrapper for nip04/nip44 encrypt/decrypt (DM flows can hang the same way).Confirmed by Steffen; merged to dev. UI waiting-state and nip04/nip44 wrapping remain as optional follow-ups (see previous comment).