10 pre-existing e2e failures in the wider calendar suite (not caused by #62/#65) #68

New issue

Open

opened 2026-07-30 14:11:52 +00:00 by laoc · 0 comments

laoc commented

2026-07-30 14:11:52 +00:00

Owner

Recording these so they are not mistaken for regressions from the #62 / #65 work during hand-testing.

Measured by TestOER at 2df1c8bd (the #65 branch): seven calendar/detail e2e files gave 44 passed / 10 failed / 1 skipped. Running the same failing files at dev (b82bfe9c, before #66) gave the same 10, identical list. So they are pre-existing on dev and independent of both PRs.

calendar-context-menu.test.js   4   dialog#event-details-modal never becomes visible
calendar-ui-redesign.test.js    4   footer not visible / min-h-screen wrapper / filter chips
calendar.test.js:43             1   dialog#event-details-modal never becomes visible
event-detail.test.js:34         1   article detail page content

The two files that actually exercise CalendarEventModal are green: calendar-creation.test.js 10/10 and calendar-editing.test.js 10/10, including #62's three on first attempt.

At least one is #39's family

[data-testid="calendar-search-input"] input[type="search"] resolves to 2 elements — the calendar search box and the people filter. That is exactly the stale-selector class #39 was about (selectors written against an older UI that now match twice), so it is likely a quick fix rather than an app bug.

The dialog#event-details-modal never becomes visible cluster (5 of the 10) is the one worth understanding before touching: it may be a genuine app regression rather than a selector problem, and it is the same shape as the modal issues in #39.

Environment notes for whoever picks this up

E2E_PORT now overrides the hardcoded playwright port — without it a leftover vite preview from another worktree gets reused and the run silently tests that tree's build (vite binds [::1] only, so it reads dead on IPv4 and healthy on IPv6).
Git worktrees have no node_modules/.bin, so pnpm lint / pnpm check die with prettier: command not found and read as a failing lint rather than an unrun one. Prepend the main checkout's node_modules/.bin to PATH.
Seeded calendar events live on the 17002 e2e relay only; a 17003 query looks empty on a perfectly healthy relay.
A publish is not visible on the e2e relays for ~4-8s, so a relay assertion right after waitForURL flakes as "never published".

Recording these so they are not mistaken for regressions from the #62 / #65 work during hand-testing. Measured by TestOER at `2df1c8bd` (the #65 branch): seven calendar/detail e2e files gave **44 passed / 10 failed / 1 skipped**. Running the same failing files at **`dev` (`b82bfe9c`, before #66)** gave **the same 10, identical list**. So they are pre-existing on `dev` and independent of both PRs. ``` calendar-context-menu.test.js 4 dialog#event-details-modal never becomes visible calendar-ui-redesign.test.js 4 footer not visible / min-h-screen wrapper / filter chips calendar.test.js:43 1 dialog#event-details-modal never becomes visible event-detail.test.js:34 1 article detail page content ``` **The two files that actually exercise `CalendarEventModal` are green:** `calendar-creation.test.js` 10/10 and `calendar-editing.test.js` 10/10, including #62's three on first attempt. ## At least one is #39's family `[data-testid="calendar-search-input"] input[type="search"]` resolves to **2 elements** — the calendar search box and the people filter. That is exactly the stale-selector class #39 was about (selectors written against an older UI that now match twice), so it is likely a quick fix rather than an app bug. The `dialog#event-details-modal never becomes visible` cluster (5 of the 10) is the one worth understanding before touching: it may be a genuine app regression rather than a selector problem, and it is the same shape as the modal issues in #39. ## Environment notes for whoever picks this up - `E2E_PORT` now overrides the hardcoded playwright port — without it a leftover `vite preview` from another worktree gets reused and the run silently tests that tree's build (`vite` binds `[::1]` only, so it reads dead on IPv4 and healthy on IPv6). - Git worktrees have no `node_modules/.bin`, so `pnpm lint` / `pnpm check` die with `prettier: command not found` and read as a failing lint rather than an unrun one. Prepend the main checkout's `node_modules/.bin` to `PATH`. - Seeded calendar events live on the `17002` e2e relay only; a `17003` query looks empty on a perfectly healthy relay. - A publish is not visible on the e2e relays for ~4-8s, so a relay assertion right after `waitForURL` flakes as "never published".

No labels

bug

discussion

enhancement

No milestone

No project

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference

edufeed/edufeed-app#68

No description provided.

Rows
Columns