After editing a calendar event, community selection is lost and must be re-selected #8

Closed
opened 2026-07-08 10:43:14 +00:00 by laoc · 3 comments
Owner

Report (Comenius test report)

etwas irritierend: muss ich nach Bearbeitung nochmal neu die Communities auswählen?

When editing an existing calendar event, the communities it was shared with are not pre-selected in the edit form — the user has to pick them again, and it is unclear whether not re-picking them un-shares the event.

Screenshot from the report:
community selection after edit

Expected

The edit form pre-selects the communities the event is already shared with, and saving without changes keeps the sharing state untouched.

## Report (Comenius test report) > etwas irritierend: muss ich nach Bearbeitung nochmal neu die Communities auswählen? When editing an existing calendar event, the communities it was shared with are not pre-selected in the edit form — the user has to pick them again, and it is unclear whether not re-picking them un-shares the event. Screenshot from the report: ![community selection after edit](https://pad.gwdg.de/uploads/a83cfc72-797d-4fdc-b36b-3813de552de8.png) ## Expected The edit form pre-selects the communities the event is already shared with, and saving without changes keeps the sharing state untouched.
Author
Owner

Fixed on branch fix/issue-8-edit-communities. This was worse than a UI irritation:

  • updateEvent extracted only the FIRST h-tag from the existing event, so editing an event shared with several communities silently un-shared it from all but one.
  • The edit modal showed the community selector unchecked and ignored it on save.

Now: the edit modal pre-selects the communities the event is already shared with; saving applies the (possibly edited) selection, so unchanged selections keep the sharing exactly as it was, and un-checking really un-shares. h-tags pointing at communities the editor has not joined (not rendered by the selector) are preserved through save and the Select-all/Deselect-all bulk actions.

Covered by new unit tests for the h-tag handling in updateEvent. The modal flow itself was verified by code review + type check; a full e2e pass over calendar editing would be a good follow-up before deploy.

Fixed on branch `fix/issue-8-edit-communities`. This was worse than a UI irritation: - `updateEvent` extracted only the FIRST h-tag from the existing event, so editing an event shared with several communities silently un-shared it from all but one. - The edit modal showed the community selector unchecked and ignored it on save. **Now:** the edit modal pre-selects the communities the event is already shared with; saving applies the (possibly edited) selection, so unchanged selections keep the sharing exactly as it was, and un-checking really un-shares. h-tags pointing at communities the editor has not joined (not rendered by the selector) are preserved through save and the Select-all/Deselect-all bulk actions. Covered by new unit tests for the h-tag handling in `updateEvent`. The modal flow itself was verified by code review + type check; a full e2e pass over calendar editing would be a good follow-up before deploy.
Author
Owner

The remaining part of the test report (share invisible in feed/upcoming, unchecked checkbox) was investigated and fixed under #21 — see the causal chain there. The edit-modal pre-selection from this issue is unchanged and awaiting re-test.

The remaining part of the test report (share invisible in feed/upcoming, unchecked checkbox) was investigated and fixed under #21 — see the causal chain there. The edit-modal pre-selection from this issue is unchanged and awaiting re-test.
Author
Owner

Confirmed by Steffen after retest (edit pre-selection + share flow). Merged to dev together with the #21 fixes.

Confirmed by Steffen after retest (edit pre-selection + share flow). Merged to dev together with the #21 fixes.
laoc closed this issue 2026-07-09 09:21:11 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
edufeed/edufeed-app#8
No description provided.