After editing a calendar event, community selection is lost and must be re-selected #8
Labels
No labels
bug
discussion
enhancement
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set
Reference
edufeed/edufeed-app#8
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Report (Comenius test report)
When editing an existing calendar event, the communities it was shared with are not pre-selected in the edit form — the user has to pick them again, and it is unclear whether not re-picking them un-shares the event.
Screenshot from the report:

Expected
The edit form pre-selects the communities the event is already shared with, and saving without changes keeps the sharing state untouched.
Fixed on branch
fix/issue-8-edit-communities. This was worse than a UI irritation:updateEventextracted only the FIRST h-tag from the existing event, so editing an event shared with several communities silently un-shared it from all but one.Now: the edit modal pre-selects the communities the event is already shared with; saving applies the (possibly edited) selection, so unchanged selections keep the sharing exactly as it was, and un-checking really un-shares. h-tags pointing at communities the editor has not joined (not rendered by the selector) are preserved through save and the Select-all/Deselect-all bulk actions.
Covered by new unit tests for the h-tag handling in
updateEvent. The modal flow itself was verified by code review + type check; a full e2e pass over calendar editing would be a good follow-up before deploy.The remaining part of the test report (share invisible in feed/upcoming, unchecked checkbox) was investigated and fixed under #21 — see the causal chain there. The edit-modal pre-selection from this issue is unchanged and awaiting re-test.
Confirmed by Steffen after retest (edit pre-selection + share flow). Merged to dev together with the #21 fixes.