fix(http): expire idle sessions so their relay sockets close #3

Merged
laoc merged 2 commits from fix/relay-socket-leak into main 2026-11-10 08:29:52 +00:00
Owner

Production (2026-11-10) showed 397 ESTABLISHED sockets from the nope-mcp container to amb-relay.edufeed.org: every MCP session builds its own relay clients (own SimplePool, src/session.ts) and is disposed only on DELETE or shutdown — edufeed-app's Termi opened one session per tool call and never sent DELETE.

  • Sessions idle for 10 min with nothing in flight are closed and disposed (sessionIdleMs; an open SSE stream counts as in flight); an expired session id answers 404 so clients re-initialize.
  • AMBRelayClient.close() uses pool.destroy(), so relays removed via remove_relay close too.
  • Tests: test/transport/sessionIdle.test.ts (undeleted session is disposed, then 404) and a real-WebSocket case in test/relay/realRelayTimeout.test.ts (0 sockets after close()); both fail without the fix. npm test 1080 passed; build clean.

edufeed-app is being changed to reuse one session per process (and to handle the 404 by re-initializing).

Squash-merge, please — then the homelab role re-run pulls :main.

Production (2026-11-10) showed 397 ESTABLISHED sockets from the nope-mcp container to amb-relay.edufeed.org: every MCP session builds its own relay clients (own SimplePool, `src/session.ts`) and is disposed only on DELETE or shutdown — edufeed-app's Termi opened one session per tool call and never sent DELETE. - Sessions idle for 10 min with nothing in flight are closed and disposed (`sessionIdleMs`; an open SSE stream counts as in flight); an expired session id answers 404 so clients re-initialize. - `AMBRelayClient.close()` uses `pool.destroy()`, so relays removed via remove_relay close too. - Tests: `test/transport/sessionIdle.test.ts` (undeleted session is disposed, then 404) and a real-WebSocket case in `test/relay/realRelayTimeout.test.ts` (0 sockets after `close()`); both fail without the fix. `npm test` 1080 passed; build clean. edufeed-app is being changed to reuse one session per process (and to handle the 404 by re-initializing). Squash-merge, please — then the homelab role re-run pulls `:main`.
edufeed-app opens one MCP session per tool call and never sends DELETE.
Each session builds its own AMBRelayClients (session.ts), disposed only on
transport close, so every session's WebSockets stayed open forever (397
sockets to amb-relay after ~556 sessions). Sessions with no request in
flight for 10 minutes are now closed, which disposes their clients.
AMBRelayClient.close() now destroys the whole pool, so relays removed from
the set after use are closed too.
laoc merged commit 1b1e1ed27d into main 2026-11-10 08:29:52 +00:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
edufeed/nope-mcp!3
No description provided.